DIP-273 Content Addressing #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbiggs
force-pushed
the
proposal/DIP-273_Content_Addressing
branch
from
bbce502
to
9332b55
Compare
* Update the definition of DSNP Content Hash to include DSNP CIDs * Change ProfileResource to use bytes, not string, for cid field, in line with Announcement usage * Update Activity Content Hash extension to include CID option * Update various example hashes to use CIDv1 * Update to pre-1.3.0 versioning and sync prerelease changelogs
wesbiggs
force-pushed
the
proposal/DIP-273_Content_Addressing
branch
from
9332b55
to
c571222
Compare
audreyt
reviewed
Jul 3, 2024
pages/DSNP/Identifiers.md
Outdated
| @@ -69,9 +70,9 @@ In order for DSNP applications to interoperate, the required functionality is li | |||
|
|
|||
| - CID version: MUST be version 1, in order to distinguish CIDs from simple multihash values in situations where either may be used | |||
| - Hash algorithm: MUST be `sha2-256` or `blake2b-256` | |||
| - Encoding: MUST be `base58btc` or `base32` | |||
| - Codec: MUST be `dag-pb` for data 256*1024 bytes or longer; `raw` for data less than 256*1024 bytes | |||
There was a problem hiding this comment.
Adding backslash before * helps markdown to disambiguate:
- Codec: MUST be
dag-pbfor data 256*1024 bytes or longer;rawfor data less than 256*1024 bytes
added 7 commits
August 2, 2024 13:02
…ported types only. Announcements have been updated to use strings for contentHash and targetContentHash fields.
wilwade
reviewed
Aug 12, 2024
|
|
||
| ```json | ||
| { | ||
| "hash": [ | ||
| "QmQNHNfHnbgJJ6nK4UPx2VtTUCafAKCbqZJ6ZRYUGjoeFj", | ||
| "2DrjgbGgSsXRhTiBWckoVwBFC6H4qiBWWNumSsRwdUt82YnTdN" | ||
| "bciqgb7tvyyqn6tw4amtdj7funn5ockup6ldrkap4o5ubd77od6awi4y", |
There was a problem hiding this comment.
I'm getting a different value for the hash of the dsnp_whitepaper than this is giving me.
- Perhaps it is the older version of the whitepaper the hash is of?
- Different hash setup that is reading the file differently than I did?
- I tried
sha256sumon mac and a random online hasher.
- I tried
The digest I expected from hashing the file was 0x36d37cf984565f2151ccea050e0bcecf44801b4c89971654c7308dc2338ce7ea
However the digest from this multihash appears to be 0x60fe75c620df4edc032634fcb46b7ae12a8ff2c71501fc776811ffee1f816473
There was a problem hiding this comment.
Yep, my mistake. Will fix.
| "QmQNHNfHnbgJJ6nK4UPx2VtTUCafAKCbqZJ6ZRYUGjoeFj", | ||
| "2DrjgbGgSsXRhTiBWckoVwBFC6H4qiBWWNumSsRwdUt82YnTdN" | ||
| "bciqgb7tvyyqn6tw4amtdj7funn5ockup6ldrkap4o5ubd77od6awi4y", | ||
| "bdyqdua4t4pxgy37mdmjyqv3dejp5betyqsznimpneyujsur23yubzna" |
There was a problem hiding this comment.
Same for this one, so I think it might just be we are using different files.
shannonwells
approved these changes
Aug 12, 2024
saraswatpuneet
approved these changes
Aug 12, 2024
| | emoji | `BYTE_ARRAY` | `STRING` | `UTF8` | | ||
| | fromId | `INT64` | `INT(64, false)` | `UINT_64` | | ||
| | inReplyTo | `BYTE_ARRAY` | `STRING` | `UTF8` | | ||
| | targetContentHash | `BYTE_ARRAY` | `STRING` | `UTF8` | |
There was a problem hiding this comment.
Note: Confirming on gateway side this is already updated
shannonwells
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DSNP should provide affordances for finding content that do not rely on a single DNS-based point of failure for content hosting.
More in the original discussion: #273
Solution
Enhance the specification to treat URLs in Announcements as suggestions rather than canonical locations for content.
Provide a simple and well-specified set of hashes and encodings that can be used consistently throughout the protocol.
Use IPFS CIDv1 specifically for locating profiles.
Change summary:
contentAddressfieldcontentHashandtargetContentHashfields.